Upgraded kotlin and Android #158
Merged
+161
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kcw-grunt
commented
Jan 21, 2024
kcw-grunt
commented
- set the min SDKs
- added helper code in Android Manifest to avoid the error when merging
- refactored per deprecations
- set the min SDKs - added helper code in Android Manifest to avoid the error when merging - refactored per deprecations Signed-off-by: kcw-grunt <[email protected]>
- added constants and tweaked tne config to avoid merge manifest errors - updated gitignore Signed-off-by: kcw-grunt <[email protected]>
kcw-grunt
added
the
🦟 critical bug
- updated gitignore - added perms Signed-off-by: kcw-grunt <[email protected]>
josikie
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Cool! Thank you! @kcw-grunt
Why do we use 34 on compileSdkVersion?
Google are requriing all apps to ship with 33 as a minimum. But when I upgraded, alot of the tools need 34.
|
|
Noted! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.